Removing deprecated call to Configuration::setSchemaAssetsFilter() + extendable #935
Conversation
| $connectionFilters = []; | ||
| foreach ($filters as $id => $tagAttributes) { | ||
| foreach ($tagAttributes as $attributes) { | ||
| $name = isset($attributes['connection']) ? $attributes['connection'] : $container->getParameter('doctrine.default_connection'); |
There was a problem hiding this comment.
should ignoring the name apply it to the default connection, or to all connections ?
There was a problem hiding this comment.
I was wondering about this too. Making it apply to all connections is actually more useful - as, for example, Symfony's session system could (in theory) say: "Hey, ignore a session table that exits in any connection... I'm not sure which connection is used for the PDO instance I'm using".
But, that also seems like a possible, legitimate edge-case: I want to ignore session on connection 1, but I really DO have a session table on connection2 that I'm managing.
There was a problem hiding this comment.
I agree with Ryan here: users should know which connection handles which tables and can build their ignore lists accordingly.
weaverryan
force-pushed
the
dbal_filter_plugin
branch
from
f724b13
to
40493af
Compare
|
Feedback handled! |
weaverryan
force-pushed
the
dbal_filter_plugin
branch
from
77ed9d6
to
1c41376
Compare
|
Updated and rebased! Thanks for checking it! |
|
Some tests still seem to fail: https://travis-ci.org/doctrine/DoctrineBundle/jobs/514116227#L347
|
weaverryan
force-pushed
the
dbal_filter_plugin
branch
from
1c41376
to
8049933
Compare
|
Sorry about that! It's better now - only php nightly failing for unrelated reasons. |
alcaeus
force-pushed
the
dbal_filter_plugin
branch
2 times, most recently
from
80a93e7
to
38d32c2
Compare
…ssion() ... and making the schema filter stuff a "plugin" system, which is the intention of the new way it's handled in doctrine/dbal
alcaeus
force-pushed
the
dbal_filter_plugin
branch
from
38d32c2
to
7c1d1da
Compare
|
I've rebased the branch on top of master to fix build the nightly build issue and fixed CS. Thanks for building this @weaverryan! |
|
Thanks @weaverryan! |
alcaeus
added
the
⭐️ EUFOSSA Hackathon
Hi!
If you're using doctrine/dbal 2.9 or higher, this removes the deprecated call to
Configuration:: setFilterSchemaAssetsExpression(). It also makes the "schema filter" extendable via a tag. The use-case is when a 3rd-party bundle manages a table automatically for you through DBAL and you don't want, for example, Doctrine migrations (https://github.com/doctrine/migrations/blob/cf7f94b0bcfbd7d9c240aee759dc6619bc9ad796/lib/Doctrine/Migrations/Generator/DiffGenerator.php#L117) /doctrine:schema:updateto suggest removing that table because it's not found in the mapping metadata.One real-world use-case will be for #868: when the Doctrine transport is added to Messenger, a table will be created for storing messages (either automatically by Messenger or manually by the user - their choice). DoctrineBundle itself could use this hook to avoid migrations trying to remove that table once it's created.
Thanks!